On Sat, Jun 11, 2016 at 10:17 AM, Johannes Sixt <j6t@xxxxxxxx> wrote: > Am 10.06.2016 um 22:11 schrieb Christian Couder: >> >> --- a/run-command.c >> +++ b/run-command.c >> @@ -85,7 +85,7 @@ static inline void close_pair(int fd[2]) >> } >> >> #ifndef GIT_WINDOWS_NATIVE >> -static inline void dup_devnull(int to) >> +void dup_devnull(int to) > > > I'm not adding arguments to what we've heard on whether to use /dev/null in > this series or not. But if the outcome is to keep this patch, please remove > the #ifndef that we see in the context lines (and the matching #endif), too. > Otherwise, the build fails on Windows for each patch in the series until > this change is reverted in patch 42/44. Ok, I will find a way to avoid that build failure, though I don't test on Windows. Thanks, Christian. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html