Re: [PATCH v6 41/44] am: use be_silent in 'struct apply_state' to shut up applying patches

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



The update in 33/44 to make am call into apply that is not ready to
be called (e.g. the caller needs the dup(2) dance with /dev/null to
be silent) gets finally corrected with this step, which makes the
progress of the topic somewhat ugly and reviewing it a bit harder
than necessary.  As it stands, the last several patches in the
series smells more like "oops, we realize these things were not done
properly the first time, and here are the follow-up patches to fix
them up".

I wonder if it is a good idea to delay integrating the apply
machinery into "am" until it is ready?
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]