On Mon, Jun 6, 2016 at 2:43 AM, Eric Sunshine <sunshine@xxxxxxxxxxxxxx> wrote: >> /* >> * The commits out of the rev-list are not ancestors of >> * our ref. >> */ >> - i = read_in_full(cmd.out, namebuf, 1); >> + i = read_in_full(cmd.out, buf, 1); > > s/1/sizeof(buf)/ perhaps or does that make the intent less clear? Yeah I think so. "1" makes it obvious that we do not care about the actual content (or at least raise some eyebrows and force the reader to understand this entire function). sizeof(buf), not so much. -- Duy -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html