Stefan Beller <sbeller@xxxxxxxxxx> writes: > On Wed, Jun 8, 2016 at 3:58 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote: >> As the topic is in 'next' already, I'll leave this floating near the >> tip for now, until we can rewind the topic after the next release. > > I don't quite understand the motivation behind this commit. > > We return the last element to allow succeeding operations > access to the bottom of the stack without needing to walk it? > This makes the follow up operations faster, because we expect the stack > to be larger than 5 elements. > > ? Think how you call _append() that returns void and then set the value to the last appended item. YOu'd need to do something unwieldy like git_attr_check_append(check, attr); check->check[check->check_nr-1].value = value -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html