Jeff King <peff@xxxxxxxx> writes: > I agree it can be confusing (especially on the output side your errors > are likely deferred until the next flush). But in this particular case, > I think it's an improvement (see the patch I just sent and its > discussion of error handling). Yes, for this one, the lifetime of the file descriptor is contained within a single function and it is straight-forward to wrap it correctly inside a FILE * via fdopen() and do the error check at the end, so I think the patch is an improvement. Will queue. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html