Eric Sunshine <sunshine@xxxxxxxxxxxxxx> writes: > An embedded CR probably shouldn't happen, but I'm not convinced that > folding it out is a good idea. I would think that you'd want to > preserve the header's value verbatim. If anything, I'd expect to see > the regex tightened to: > > s/\r?\n$//; Yes, that would be more sensible than silently removing \r in the middle which _is_ a sign of something funny going on. > Alternately, consider using 'chop' or 'chomp'. Even if you use chomp(), you'd still need to worry about possible \r at the end, no? -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html