On 06/08/2016 06:09 PM, Junio C Hamano wrote:
Samuel GROOT <samuel.groot@xxxxxxxxxxxxxxxx> writes:
Actually we had issues when trying to refactor send-email's email
parsing loop [1]. Email addresses in output file `commandeline1` in
tests weren't sorted the same way as the reference file it was
compared to. E.g.:
!nobody@xxxxxxxxxxx!
!author@xxxxxxxxxxx!
!one@xxxxxxxxxxx!
!two@xxxxxxxxxxx!
And the reason why these addresses that are collected from the same
input (i.e. command line, existing e-mail fields, footers, etc.) are
shown in different order in your implementation is...?
It's not shown in different order in our implementation, it's just a
leftover of my refactor attempt [1].
Maybe it's a bad idea to increase tests' complexity, but IMHO tests
should be independent to the addresses' order.
Plus, it would help refactor in the future, the data being processed
differently: parsing and processing in different subroutines rather than
doing everything in one gigantic loop.
We can drop it if necessary, but it may be useful to make
git-send-email.perl easier to maintain.
[1] * http://article.gmane.org/gmane.comp.version-control.git/295753
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html