On Tue, Jun 7, 2016 at 12:20 AM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > Mehul Jain <mehul.jain2029@xxxxxxxxx> writes: > >> If "log.showSignature=true", then there is no way to override it using >> command line switch. >> >> Teach git-log and related commands about "--no-showSignature" command >> line option. > > Doesn't that suggest that 1/2 alone will cause users problems? The > users can by mistake set the configuration variable and there is no > way for them to override it from the command line. > > If you swap the order of the two patches, the topic makes more > sense. I.e. > > [1/2] log: add "--no-show-signature" command line option > > makes "git log --show-signature --no-show-signature" to run without > GPG checks, which by itself is a worthy change. And then > > [2/2] log: add log.showSignature configuration variable > > makes revs->show_signature default to the configured value, instead > of always initializing it to false. Yes, it does make sense to swap the order of the patches. I will do a re-roll soon. Thanks, Mehul -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html