"brian m. carlson" <sandals@xxxxxxxxxxxxxxxxxxxx> writes: > Coccinelle (http://coccinelle.lip6.fr/) is a program which performs > mechanical transformations on C programs using semantic patches. These > semantic patches can be used to implement automatic refactoring and > maintenance tasks. > > Add a set of basic semantic patches to convert common patterns related > to the struct object_id transformation. > > Signed-off-by: brian m. carlson <sandals@xxxxxxxxxxxxxxxxxxxx> > --- > I realize the name and location of this file might be suboptimal. > Suggestions on better locations and filenames would be appreciated. Once is_null_sha1() is updated to is_null_oid(), the first rewrite definition would become useless, no? I am not sure what the point is to keep this file in our history. > > standard.cocci | 83 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 83 insertions(+) > create mode 100644 standard.cocci > > diff --git a/standard.cocci b/standard.cocci > new file mode 100644 > index 00000000..0f068252 > --- /dev/null > +++ b/standard.cocci > @@ -0,0 +1,83 @@ > +@@ > +expression E1; > +@@ > +- is_null_sha1(E1.hash) > ++ is_null_oid(&E1) > + > +@@ > +expression E1; > +@@ > +- is_null_sha1(E1->hash) > ++ is_null_oid(E1) > + > +@@ > +expression E1; > +@@ > +- sha1_to_hex(E1.hash) > ++ oid_to_hex(&E1) > + > +@@ > +expression E1; > +@@ > +- sha1_to_hex(E1->hash) > ++ oid_to_hex(E1) > + > +@@ > +expression E1; > +@@ > +- hashclr(E1.hash) > ++ oidclr(&E1) > + > +@@ > +expression E1; > +@@ > +- hashclr(E1->hash) > ++ oidclr(E1) > + > +@@ > +expression E1, E2; > +@@ > +- hashcmp(E1.hash, E2.hash) > ++ oidcmp(&E1, &E2) > + > +@@ > +expression E1, E2; > +@@ > +- hashcmp(E1->hash, E2->hash) > ++ oidcmp(E1, E2) > + > +@@ > +expression E1, E2; > +@@ > +- hashcmp(E1->hash, E2.hash) > ++ oidcmp(E1, &E2) > + > +@@ > +expression E1, E2; > +@@ > +- hashcmp(E1.hash, E2->hash) > ++ oidcmp(&E1, E2) > + > +@@ > +expression E1, E2; > +@@ > +- hashcpy(E1.hash, E2.hash) > ++ oidcpy(&E1, &E2) > + > +@@ > +expression E1, E2; > +@@ > +- hashcpy(E1->hash, E2->hash) > ++ oidcpy(E1, E2) > + > +@@ > +expression E1, E2; > +@@ > +- hashcpy(E1->hash, E2.hash) > ++ oidcpy(E1, &E2) > + > +@@ > +expression E1, E2; > +@@ > +- hashcpy(E1.hash, E2->hash) > ++ oidcpy(&E1, E2) -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html