Junio C Hamano <gitster@xxxxxxxxx> writes: > I am wondering if this "we do not include status and do not ask > run_status() about commitable bit" codepath should share more with > the other side, which you do not touch at all with this series, > which in turn must be doing the right thing already, apparently > without having to know anything about the SHIFT_INTENT_TO_ADD > hackery. > > Or does "git commit" that uses run_status() still allow an empty > commit after this patch? Ah, I didn't see what 2/4 does. The duplication still does make this look an ugly hack, but I can see that the series is at least internally consistent. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html