Re: [PATCH] completion: complete --move for git branch

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jun 6, 2016 at 5:16 PM, Remi Galan Alfonso
<remi.galan-alfonso@xxxxxxxxxxxxxxxxxxxxxxx> wrote:
>
> Hi,
>
> Ville Skyttä <ville.skytta@xxxxxx> writes:
> >          while [ $c -lt $cword ]; do
> >                  i="${words[c]}"
> >                  case "$i" in
> > -                -d|-m)        only_local_ref="y" ;;
> > -                -r)        has_r="y" ;;
> > +                -d|-m|--move)        only_local_ref="y" ;;
>
> "While you're at it" you might want to do the same thing for
> `--delete`.

I'm afraid the "while I'm at it" would never end if I start looking
deeper into missing things there, so I'd prefer this self contained
one I keep running into myself applied first.

> > +                -r)                has_r="y" ;;
>
> You are introducing an additional tab here that you probably didn't
> want.

It was intentionally added it to keep "only_local_ref" and "has_r"
tab-aligned the way they already were.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]