Hi, On Fri, 3 Jun 2016, Duy Nguyen wrote: > On Thu, Jun 2, 2016 at 11:49 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > > > Does "basename()" used here know '/' and '\' can both be a directory > > separator, or does worktree->path have a normalized representation of > > the path, i.e. '/' is the only directory separator? > > basename() does (or I think so because Windows has its own version). > worktree->path always uses '/' but the command line option can come with > either '/' or '\'. Probably safest to accept both. It is very easy to see what the Windows version of basename() does by looking at our very own test code: https://github.com/git/git/blob/v2.8.3/test-path-utils.c#L71-L110 Short answer: basename() knows that both '/' and '\' are directory separators. Ciao, Dscho -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html