With the commits f2f02675 and 5096d490 we have been converted in some files the call from snprintf/sprintf/strcpy to xsnprintf. This patch converts the remaining calls to snprintf with xsnprintf under the following conditions: - The call to snprintf does not control the outcome of the command or the presence of truncation errors. - A call to snprintf can generate a fatal error, directly or indirectly. The other few remaining cases in which a call to snprintf can generate a soft error have not been changed. Signed-off-by: Elia Pinto <gitter.spiros@xxxxxxxxx> --- builtin/index-pack.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/builtin/index-pack.c b/builtin/index-pack.c index e8c71fc..c032fe7 100644 --- a/builtin/index-pack.c +++ b/builtin/index-pack.c @@ -1443,7 +1443,7 @@ static void final(const char *final_pack_name, const char *curr_pack_name, printf("%s\n", sha1_to_hex(sha1)); } else { char buf[48]; - int len = snprintf(buf, sizeof(buf), "%s\t%s\n", + int len = xsnprintf(buf, sizeof(buf), "%s\t%s\n", report, sha1_to_hex(sha1)); write_or_die(1, buf, len); -- 2.9.0.rc1.265.geb5d750 -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html