On Sat, May 28, 2016 at 10:17:19AM +0200, Torsten Bögershausen wrote: > On 28.05.16 07:33, Mike Hommey wrote: > > On Sat, May 28, 2016 at 07:02:01AM +0200, Torsten Bögershausen wrote: > >> On 27.05.16 23:59, Mike Hommey wrote: > >>> On Fri, May 27, 2016 at 04:24:20PM +0200, Torsten Bögershausen wrote: > >>>> On 27.05.16 04:27, Mike Hommey wrote: > >>>>> Changes from v7: > >>>>> - Fixed comments. > >>>>> > >>>>> Mike Hommey (9): > >> All in all, a great improvement. > >> 2 things left. > >> - The comment about [] is now stale, isn't it ? > > No, it's still valid at this point, that's what the 2nd argument to > > host_end (0) does. > > > > Mike > > The protocol (specific) code doesn't do this anymore, > because that is now common to all protocols. > > > /* > * Don't do destructive transforms now, the > * '[]' unwrapping is done in get_host_and_port() > */ > I'm not following what you're saying. The code explicitly calls host_end so that it doesn't remove the square brackets from the string it's passed. That's what the comment says, and that's what happens. Mike -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html