Hi Junio, On Thu, 26 May 2016, Junio C Hamano wrote: > Johannes Schindelin <Johannes.Schindelin@xxxxxx> writes: > > > I do not see this patch in 'pu'... Anything I can do to get this into > > 'master' eventually? > > The reason why I left it in my inbox was because I couldn't tell if > this was a final submission with concensus among Git developers on > Windows, or I should be giving a chance to comment to some folks who > work on Windows port but are not necessarily closely communicating > with you. > > If the message were Cc'ed to J6t, I would probably have queued it on > 'pu' and marked it as "Will merge after waiting for a few days" in > What's cooking. Hannes does not use Git for Windows' SDK, but instead uses an old MSys-based development environment that predates even msysGit (which was the SDK used to develop Git for Windows 1.x). His environment most notably does *not* use MinTTY, and therefore is unaffected by the bug that this patch fixes. That was the entire reasoning why I did not ask Hannes to review this patch: it is unlikely that he knows about the issue, let alone about the correctness of the implementation of this patch. The implementation relies on some really low-level knowledge of the Windows internals, which Karsten reverse-engineered and I verified. Thanks, Dscho -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html