Re: [PATCH] xemit.c: fix a [-Wchar-subscripts] compiler warning

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



[sorry for duplicate]

Am 26.05.2016 um 01:06 schrieb Ramsay Jones:

While compiling on cygwin (x86_64), gcc complains thus:

       CC xdiff/xemit.o
   xdiff/xemit.c: In function ‘is_empty_rec’:
   xdiff/xemit.c:163:2: warning: array subscript has type ‘char’ [-Wchar-subscripts]
     while (len > 0 && isspace(*rec)) {
     ^

Ah, it's not using our own isspace(), which works fine with signed chars, because it doesn't include git-compat-util.h. I'm spoilt by those char classifier macros that can be actually used with chars.. Thanks for catching!

René

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]