Hi Torsten, On Wed, 25 May 2016, Torsten Bögershausen wrote: > On 05/24/2016 01:57 PM, Johannes Schindelin wrote: > > > > On Tue, 24 May 2016, Torsten Bögershausen wrote: > > > > > if core.filemode is true, Git for Windows could: > > > a) Behave as today, report changed files (filemode) > > > b) Give warning to the user (and report changed filemode) > > > c) Error out, saying misconfigured worktree > > > d) use core.filemode = false anyway. > > > e) Give a warning and use core.filemode = false anyway. > > > > > > At the moment I tend for c), as it makes it clear what is going wrong, > > > what do you think ? > > > > The problem with that is that we would need to probe again. > > The probing for the filemode: > Wouldn't it be enough to run lstat() on .git/ ? What about `git diff --no-index`? There is no `.git/` to probe there. > If the user-execuatable bit is not set, but core.filemode is true, error > out ? That would not cost too much. I think it would cost us a nice and clean logic ;-) > > Or dictate for all eternity that Git for Windows cannot determine the > > executable bit (but who knows for certain?) > > Can we can limit the eternity until the day when Windows can determine > the executable bit ? The point is: I will have forgotten by next week what we talked about (there are way too many things going on in my life), and if and when compat/mingw.c will be taught to infer the executable bit, I am prone to forget that warning (if we introduce it). Therefore, out of entirely practical considerations, I favor the status quo. Ciao, Dscho