Hey Christian, On Tue, May 24, 2016 at 1:03 PM, Christian Couder <christian.couder@xxxxxxxxx> wrote: > On Tue, May 24, 2016 at 9:21 AM, Pranit Bauva <pranit.bauva@xxxxxxxxx> wrote: >> diff --git a/git-bisect.sh b/git-bisect.sh >> index 7d7965d..cd39bd0 100755 >> --- a/git-bisect.sh >> +++ b/git-bisect.sh >> @@ -210,7 +210,7 @@ bisect_start() { >> eval "$eval true" && >> if test $must_write_terms -eq 1 >> then >> - write_terms "$TERM_BAD" "$TERM_GOOD" >> + git bisect--helper --write-terms "$TERM_BAD" "$TERM_GOOD" || exit > > This `|| exit` is not needed because... > >> fi && >> echo "git bisect start$orig_args" >>"$GIT_DIR/BISECT_LOG" || exit > > ... there is an `|| exit` on the line above (which is chained using > `&&` to the previous lines). Nice notice. I will send a re-roll Regards, Pranit Bauva -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html