Hi Pranit, On Fri, 20 May 2016, Pranit Bauva wrote: > On Mon, May 16, 2016 at 12:10 PM, Johannes Schindelin > <Johannes.Schindelin@xxxxxx> wrote: > > > > On Sat, 14 May 2016, Pranit Bauva wrote: > > > >> Reimplement the `bisect_voc` shell function in C. This is a too small > >> function to be called as a subcommand though the working of this > >> function has been tested by calling it as a subcommand. > > > > This leaves me puzzled as to what this patch is supposed to do. Maybe > > rename this function to have a more intuitive name, and then throw in a > > patch that makes use of the function? > > Are you suggesting to first have an introductory patch which will > rename the function in the shell script and then this patch which will > convert the "new" shell function to C? I can do this. I have to think > of a nice name. How does 'good_or_bad" sound? For such a short function, I would simply use a more sensible name in the C version of the function. In other words, I would not bother with an extra patch but do it all in the same patch, describing it well in the commit message. Ciao, Johannes -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html