On Sat, May 21, 2016 at 7:17 PM, Mike Hommey <mh@xxxxxxxxxxxx> wrote: > Signed-off-by: Mike Hommey <mh@xxxxxxxxxxxx> > --- > diff --git a/connect.c b/connect.c > @@ -742,6 +742,12 @@ struct child_process *git_connect(int fd[2], const char *url, > transport_check_allowed("ssh"); > get_host_and_port(&ssh_host, &port); > > + /* get_host_and_port may not return a port even when > + * there is one: In the [host:port]:path case, > + * get_host_and_port is called with "[host:port]" and > + * returns "host:port" and NULL. > + * In that specific case, we still need to split the > + * port. */ Style: /* * This is a multi- * line comment. */ > if (!port) > port = get_port(ssh_host); -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html