On Thu, May 19, 2016 at 3:49 AM, Mike Hommey <mh@xxxxxxxxxxxx> wrote: > On Fri, Apr 08, 2016 at 08:35:51AM -0400, Mike Rappazzo wrote: >> On Fri, Apr 8, 2016 at 7:47 AM, Duy Nguyen <pclouds@xxxxxxxxx> wrote: >> > On Mon, Apr 4, 2016 at 8:42 AM, Michael Rappazzo <rappazzo@xxxxxxxxx> wrote: >> >> Executing `git-rev-parse --git-common-dir` from the root of the main >> >> worktree results in '.git', which is the relative path to the git dir. >> >> When executed from a subpath of the main tree it returned somthing like: >> >> 'sub/path/.git'. Change this to return the proper relative path to the >> >> git directory (similar to `--show-cdup`). >> > >> > I faced a similar problem just a couple days ago, I expected "git >> > rev-parse --git-path" to return a path relative to cwd too, but it >> > returned relative to git dir. The same solution (or Eric's, which is >> > cleaner in my opinion) applies. --shared-index-path also does >> > puts(git_path(... and has the same problem. Do you want to fix them >> > too? >> >> Sure, I can do that. I will try to get it up soon. > > If I'm not mistaken, it looks like this fell off your radar. (I haven't > seen an updated patch, and it doesn't look like the fix made it to any > git branch). Would you mind updating? > > Cheers, > > Mike There is a newer version submitted on May 6th[1]. Eric Sunshine has submitted a patch [2] which fixes up t1500. It looks like that is in a stable form, so I will rebase my v2 onto those changes, and resubmit in the near future. [1] http://thread.gmane.org/gmane.comp.version-control.git/293778 [2] http://thread.gmane.org/gmane.comp.version-control.git/294999 -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html