On Thu, May 19, 2016 at 12:10:31PM +0200, Antoine Queru wrote: > > I'm not sure whether it is worth hiding the first two options. We > > typically hide "internal" options like this for user-facing programs, so > > as not to clutter the "-h" output. But upload-pack isn't a user-facing > > program. Anybody who is calling it directly with "-h" may be interested > > in even its more esoteric options. > > In fact, to do this, I looked at builtin/receive-pack.c, where the parser API > was already implemented, and these first two options were hidden. There were > also no description for any options, so I thought it was not needed. Maybe we > could update this file too ? Yeah, I don't think it's that bad to hide them, and perhaps consistency with receive-pack is better. AFAICT, descriptions for hidden options are pointless; they are never shown (in fact, it seems like OPT_HIDDEN_BOOL probably shouldn't even take such an option?). But the non-hidden options _do_ need non-NULL descriptions. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html