Re: sscanf/strtoul: parse integers robustly

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jim Meyering <jim@xxxxxxxxxxxx> writes:

> diff --git a/git-compat-util.h b/git-compat-util.h
> index 139fc19..5f6a281 100644
> --- a/git-compat-util.h
> +++ b/git-compat-util.h
> @@ -301,4 +301,17 @@ static inline int prefixcmp(const char *str, const char *prefix)
>  	return strncmp(str, prefix, strlen(prefix));
>  }
>  
> +static inline int strtoul_ui(char const *s, int base, unsigned int *result)
> +{
> +	unsigned long ul;
> +	char *p;
> +
> +	errno = 0;
> +	ul = strtoul(s, &p, base);
> +	if (errno || *p || p == s || (unsigned int) ul != ul)
> +		return -1;
> +	*result = ul;
> +	return 0;
> +}
> +
>  #endif

War on sscanf is fine, but I wonder if this is small enough to
be a good candidate for inlining.


-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]