On Wed, May 11, 2016 at 9:17 AM, Christian Couder <christian.couder@xxxxxxxxx> wrote: > To libify `git apply` functionality we must make 'struct apply_state' > usable outside "builtin/apply.c". Why is this patch plopped right in the middle of a bunch of other patches which are making functions return -1 rather than die()ing? Seems out of place. > Let's do that by creating a new "apply.h" and moving > 'struct apply_state' there. I could easily see this header introduced at a very early stage when 'struct apply_state' itself is introduced, rather than introducing 'struct apply_state' in builtin/apply.c and later moving it here. > Signed-off-by: Christian Couder <chriscool@xxxxxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html