Dmitry Gutov <dgutov@xxxxxxxxx> writes: > OK, that makes sense. You might want to fix the man page, though, it > says, like the 'git diff' one, "For instance, if you configured > diff.algorithm variable to a non-default value and want to use the > default one, then you have to use --diff-algorithm=default option.". Thanks; I think the paragraph is shared among the "diff" family of commands both plumbing and Porcelain, so I'd say "patches welcome" at this point ;-). > Thanks, but we don't distribute any custom Git porcelains with > Emacs. We usually can't rely on bash being available either. The script was an illustration of the logic--I am sure elisp is much core capable scripting environment than POSIX shell. Perhaps (setq vc-diff-git-diff-use-histogram t) in ~/.emacs is not too bad ;-) > I'll have to see why we using 'git diff-index' there directly. Maybe > we could switch to 'git diff'. I do not think it is a good idea. Depending on how much understanding vc-diff wants to have on what the diff output is saying, it may want to be read and parse parts of the output; an end user who has diff.color=always can easily ruin your day. And no, running "git diff --color=never" is not a solution for that. The Porcelain "git diff" command is not bound by any promise of stable output and reserves the right to change the default to better support human users. I think the upcoming version of Git turns the diff.renames setting on by default, for example. We might even add a side-by-side diff and make it the default someday. You do not want to be reading these "fancy" output, and you cannot keep updating the invocation of "git diff" by vc-diff with unbounded number options, e.g. --no-side-by-side, that will be added to defeat configuration variables that will be invented in the future. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html