================================= SUMMARY ==================================
My micro project on adding config variable to git-commit for verbose options
is going to be merged with the master branch soon and will be available for
git 2.8.3 . I also rewrote a few shell functions in C.
My public git.git is available here[1]. I regularly keep pushing my work so
anyone interested can track me there. Feel free to participate in the
discussions going on PRs with my mentors. Your comments are valuable.
=============================== INTRODUCTION ==============================
The purpose of this project is to convert the git-bisect utility which partly
exists in the form of shell scripts to C code so as to make it more portable.
I plan to do this by converting each function to C and then calling it from
git-bisect.sh so as to use the existing test suite to test the function which
is converted.
Mentors:
Christian Couder <chriscool@xxxxxxxxxxxxx>
Lars Schneider <larsxschneider@xxxxxxxxx>
================================== Updates =================================
Things which were done in this week:
* I have sent the patches[2] for check_term_format() and write_terms() so
as to demonstrate how I am going to use the subcommand approach wherein
I will first convert a method and then call it by using a subcommand.
Then when another method is converted the previous method will be removed
from the subcommand and will instead be called from the new method. Junio
has collected this patch and queued it on a branch gitster/pb/bisect and
is available for testing on the pu branch. I am encouraging people to
test it and provide useful comments.
* I have also converted bisect_log() and bisect_voc() whose patches[3] are
sent to the list. Junio is yet to pick these up.
* I have converted the function bisect_clean_state() but its in a very
rudimentary form. Well I generally do like this. I first have a *just*
working model of a function and then I polish it by introducing the git's
API and write error handling code and resolve the style issues. Though it
is available on github[4]. The current version plainly removes the refs
using the git's API. I am quite aware that refs shouldn't be handled in this way
(this fact is constantly reminded in the docs). I am reading up on the
available methods for refs manipulation.
* I have also sent an independent patch[5] to explicitly test whether
bisection state is properly cleaned up.
* Also studied the functioning (upto an extent) of git-for-each-ref and
git-udpate ref as it is required during the conversion of
bisect_clean_state().
* The main part (I think) was that I read about the method's which handled the
refs. It was an interesting read though I did not read upon the actual
implementations of those, I mainly covered "What does the method do?" and
"How to use the method in my code?". git-grep is my best friend for this.
* I am still quite amazed by the amount of attention refs receive. Christian
explained a bit though I still don't get the feel why they are *sooo*
important. I was recently reading the Git Rev News and also seeing the
patches by Michael Haggerty and David Turner and I was quite amazed on
the amount of attention refs get.
* I also noticed a minor thing with bisect cleanups[6]. After the bisection
state is cleaned up the folder "refs/bisect/" is not removed. I pointed
this out but Christian thought it is okay the way it is.
* When I was converting the function write_terms() Christian advised to use
`|| exit` when calling it with a subcommand using `git bisect--helper
--write-terms $TERM_BAD bad` but it got the test no. 43 and 44 failing in
t6030. On a little bit investigation by Christian, these tests seem to
fail when there is a bare repo. He asked me to investigate it further.
I have currently not found enough time. Will do it in the coming week.
================================= NEXT STEPS ================================
Things which would be done in the coming week:
* Finish bisect_clean_state() conversion. I will first put it up on github
to receive comments from my mentors and then post it to the mailing list.
* Convert the function bisect_head(). I plan to convert this function and add
it as a subcommand to test the implementation but I will only send the
function without the subcommand to the mailing list because its a too small
function. Though the subcommand version will be put up on github for
everyone to verify whether it is passing the test suite like I have done it
for bisect_voc().
* Convert the function bisect_write(). I plan to convert this function and
add it as a subcommand.
* Investigate why test no. 43 and 44 are failing in t6030 with `|| exit` in
--write-terms.
================================ NOTIFICATION ==============================
I will be taking a short vacation from 16th May, 2016 to 19th May, 2016 so
I wouldn't be available via email and also will not be able to work. I intend
to make up for the lost time by working on weekends.
[1]: https://github.com/pranitbauva1997/git
[2]: http://thread.gmane.org/gmane.comp.version-control.git/294388
[3]: http://thread.gmane.org/gmane.comp.version-control.git/294571
[4]: https://github.com/pranitbauva1997/git/pull/6
[5]: http://thread.gmane.org/gmane.comp.version-control.git/294520
[6]: https://github.com/pranitbauva1997/git/pull/8
PS: Thanks to Andrew Ardill <andrew.ardill@xxxxxxxxx> on providing his comments
of how to improve the format of this update email. I have tried to make it
as exhaustive as possible.
Regards,
Pranit Bauva
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html