On 14.05.16 20:45, Junio C Hamano wrote: > Torsten Bögershausen <tboegi@xxxxxx> writes: > >> Do we need to run diff_populate_filespec() twice when src==dst ? > > Of course we do. > > src and dst may have the same path, but are coming from different > places (src may be an indexed blob while dst may be a file in the > working tree). > >> If yes, we may need to introduce a flag besides >> #define CHECK_SIZE_ONLY 1 >> #define CHECK_BINARY 2 >> to suppress the conversion warning ?? > > I do not think that belongs to diff_populate_filespec() at all. Just to remind myself: sha1_file.c: The warning should probably triggered from here, depending on the flags ? int index_fd(unsigned char *sha1, int fd, struct stat *st, enum object_type type, const char *path, unsigned flags) -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html