Pranit Bauva <pranit.bauva@xxxxxxxxx> writes:
> Not just that, it would also be fundamentally more correct as there is
> a difference between " !strcmp("good") " and " strcmp("bad") ".
Not really. As long as you are in tight control of the callers,
because we'd never call $2 with anything other than good and bad in
the original, there is no deep fundmental difference between them.
It is just "test bad != $2" makes it more clear that we are checking
if $2 is not 'bad', but strcmp(orig_term, "bad") doesn't do so as
strongly as that.
> Will do this change in a separate patch after the dust settles.
Thanks.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html