Armin Kunaschik <megabreit@xxxxxxxxxxxxxx> writes: > I fail to see why eval is really necessary here. It is necessary to work correctly with any strategy option with $IFS in it, I would think. The calling script "git-rebase" accumulates --strategy-option values after passing each of them through "rev-parse --sq-quote" for that reason. which means that eval'ed string here: > My quick and dirty hotfix is to place a > test -n "$strategy_opts" && > in front of the eval. > The tests run fine after this change. > > What do you think? I do not see why "test -n &&" is necessary here, and would be very hesitant to accept a change that nobody understands why it works. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html