Stefan Beller <sbeller@xxxxxxxxxx> writes: >> + *colon = '\0'; >> + item = string_list_lookup(expect, buf.buf); >> + *colon = ':'; > > I have been staring at this for a good couple of minutes and wondered if this > low level string manipulation is really the best way to do it. It just shows that string_list API was not designed as richly as others, compared to say the more complete API like strbuf. If it had a <ptr,len> variant, I wouldn't have needed the "temporary termination to get a string" hack. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html