Am 05.05.2016 um 11:50 schrieb Christian Couder:
On Mon, Apr 25, 2016 at 5:05 PM, Johannes Schindelin
<Johannes.Schindelin@xxxxxx> wrote:
Hi Chris,
On Sun, 24 Apr 2016, Christian Couder wrote:
diff --git a/run-command.c b/run-command.c
index 8c7115a..29d2bda 100644
--- a/run-command.c
+++ b/run-command.c
@@ -85,7 +85,7 @@ static inline void close_pair(int fd[2])
}
#ifndef GIT_WINDOWS_NATIVE
-static inline void dup_devnull(int to)
+void dup_devnull(int to)
{
The #ifndef GIT_WINDOWS_NATIVE rings very, very loud alarm bells.
Yeah, but I must say that I don't know what I should do about this.
Do you have a suggestion? Should I try to implement the same function
for Windows?
No, just remove the #ifndef brackets. There is already code in
compat/mingw.c that treats the file name "/dev/null" specially.
-- Hannes
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html