On Wed, May 04, 2016 at 12:57:31PM -0700, Junio C Hamano wrote: > > Is it worth just making this a perl script, rather than a shell script > > with a giant inline perl script? Perl is actually really good at doing > > that "grep" as it reads the file. :) > > OK. Hmm. This new version uses File::Find: > +sub lint_it { > + lint($File::Find::name) if -f; > +} > + > +find({ wanted => \&lint_it, no_chdir => 1 }, "Documentation"); That will inspect non-source files, too. Would: open(my $files, '-|', qw(git ls-files)); while (<$files>) { chomp; ... } make sense? Or a simpler but non-streaming spelling: my @files = map { chomp; $_ } `git ls-files`; Or just taking the list of files on the command line as your original did, and feeding `ls-files` from the caller. That also lets you do "link-gitlink git-foo.txt", etc. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html