Hi Dscho, On Wed, May 4, 2016 at 2:21 PM, Johannes Schindelin <Johannes.Schindelin@xxxxxx> wrote: > If your patch series contained *one* patch whose intent was to prepare for > a libified 'apply', yes, indeed, I would think that it would make for a > fine commit subject. Especially if the other patches tried to do > completely unrelated things. Then your "low-level" change would really > benefit from a "high-level" commit message: the "low-level" aspect is seen > easily enough in the patch itself, thankyouverymuch. One can also say that if the long term intent is described in the commit message and if the commit message is already "high level", then a "high level" subject on top of it doesn't provide any more benefit. A "high level" subject on top can just make it harder to relate the patch, when you only see its subject, to what it contains. > It really misrepresents my comment to pretend that I had tried to > suggest something as utterly confusing as identically repeated commit > subjects. Sorry but that was not my intent to suggest that. My intent was to try to show that there is some important value to make the subject close to the "low level" thing the patch actually does. Thanks, Christian. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html