Jeff King <peff@xxxxxxxx> writes: > On Tue, May 03, 2016 at 11:54:32AM -0700, Stefan Beller wrote: > >> As the test runs `chmod 0` on a file, we don't want to run that test >> as root. > > This somehow misses the root (no pun intended) of the issue, to me. > Perhaps: > > We `chmod 0` a file and test a case where git is unable to read it. > If the test is run as root, the permissions are ignored, and our > simulated read failure does not happen. > > The patch itself looks obviously correct. :) > > -Peff Yup, I had exactly the same reaction. Thanks. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html