On Tue, May 3, 2016 at 8:03 AM, Nguyễn Thái Ngọc Duy <pclouds@xxxxxxxxx> wrote: > "errno" is already passed in as "err". Here we should use err instead of > errno. errno is probably a copy/paste mistake in e011054 (Teach > git-update-index about gitlinks - 2007-04-12) Thanks, this version is quite sensible and doesn't trigger any feelings of discomfort[1]. [1]: http://thread.gmane.org/gmane.comp.version-control.git/293150/focus=293205 > Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@xxxxxxxxx> > --- > builtin/update-index.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/builtin/update-index.c b/builtin/update-index.c > index 1c94ca5..b8b8522 100644 > --- a/builtin/update-index.c > +++ b/builtin/update-index.c > @@ -255,7 +255,7 @@ static int process_lstat_error(const char *path, int err) > { > if (err == ENOENT || err == ENOTDIR) > return remove_one_path(path); > - return error("lstat(\"%s\"): %s", path, strerror(errno)); > + return error("lstat(\"%s\"): %s", path, strerror(err)); > } > > static int add_one_path(const struct cache_entry *old, const char *path, int len, struct stat *st) > -- > 2.8.0.rc0.210.gd302cd2 -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html