Christian Couder <christian.couder@xxxxxxxxx> writes:
> +void set_index_file(char *index_file)
> +{
> + git_index_file = index_file;
> +}
What's the rationale for this change, and more importantly, the
ownership rule for the string? When you call this function, does
the caller still own that piece of memory? When you call this
twice, where does the old value go and who is responsible for
taking care of not leaking it?
Cannot guess any of the above with no proposed log message (that
comment applies most of your patches in this series).
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html