Re: [PATCH 69/83] builtin/apply: make add_conflicted_stages_file() return -1 on error

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, May 2, 2016 at 9:36 AM, Eric Sunshine <sunshine@xxxxxxxxxxxxxx> wrote:
> On Sun, Apr 24, 2016 at 9:34 AM, Christian Couder
> <christian.couder@xxxxxxxxx> wrote:
>> Signed-off-by: Christian Couder <chriscool@xxxxxxxxxxxxx>
>> ---
>> diff --git a/builtin/apply.c b/builtin/apply.c
>> @@ -4234,8 +4234,11 @@ static void add_conflicted_stages_file(struct apply_state *state,
>>                 ce->ce_namelen = namelen;
>>                 hashcpy(ce->sha1, patch->threeway_stage[stage - 1].hash);
>>                 if (add_cache_entry(ce, ADD_CACHE_OK_TO_ADD) < 0)
>> -                       die(_("unable to add cache entry for %s"), patch->new_name);
>> +                       return error(_("unable to add cache entry for %s"),
>> +                                    patch->new_name);
>
> Is this leaking 'ce' (which is allocated a few lines above the shown context)?

Yes, thanks.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]