I went even further this time around. I'm not totally satistifed with
the resulting parse_connect_url function, but at least it feels to me
this series puts us in a better place to actually improve it further.
Mike Hommey (11):
add fetch-pack --diag-url tests for some corner cases
connect: call get_host_and_port() earlier
connect: only match the host with core.gitProxy
connect: fill the host header in the git protocol with the host and
port variables
connect: make parse_connect_url() return separated host and port
connect: group CONNECT_DIAG_URL handling code
connect: make parse_connect_url() return the user part of the url as a
separate value
connect: change the --diag-url output to separate user and host
connect: use "-l user" instead of "user@" on ssh command line
connect: actively reject git:// urls with a user part
connect: move ssh command line preparation to a separate function
connect.c | 223 ++++++++++++++++++++++++++++----------------------
t/t5500-fetch-pack.sh | 46 ++++++++---
t/t5601-clone.sh | 52 ++++++++++--
3 files changed, 204 insertions(+), 117 deletions(-)
--
2.8.1.16.gaa70619.dirty
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html