On Mon, May 02, 2016 at 02:28:12PM +0000, Elia Pinto wrote:
> + if (nopriv &&
> + (skip_prefix(out.buf + prefix_len, "Authorization:", &header)
> + || skip_prefix(out.buf + prefix_len, "Proxy-Authorization:", &header))) {
> + /* The first token is the type, which is OK to log */
> + while (isspace(*header))
> + header++;
> + /* Everything else is opaque and possibly sensitive */
The first comment there is now misleading, as we _don't_ keep the first
token (though as mentioned elsewhere, I think we should).
> +void setup_curl_trace(CURL *handle)
> +{
> + if (!trace_want(&trace_curl)) return;
Style: we always put conditional bodies on a new line, even when they
are trivial like this.
-Peff
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html