On Mon, Apr 25, 2016 at 3:36 PM, Duy Nguyen <pclouds@xxxxxxxxx> wrote: > On Sun, Apr 24, 2016 at 8:34 PM, Christian Couder > <christian.couder@xxxxxxxxx> wrote: >> Signed-off-by: Christian Couder <chriscool@xxxxxxxxxxxxx> >> --- >> builtin/apply.c | 52 ++++++++++++++++++++++++++++++---------------------- >> 1 file changed, 30 insertions(+), 22 deletions(-) >> >> diff --git a/builtin/apply.c b/builtin/apply.c >> index 6b8ba2a..268356b 100644 >> --- a/builtin/apply.c >> +++ b/builtin/apply.c >> @@ -812,7 +812,7 @@ static int gitdiff_hdrend(struct apply_state *state, >> const char *line, >> struct patch *patch) >> { >> - return -1; >> + return 1; >> } > > These are in a function group that will be called as p->fn() in > parse_git_header(). Is it possible to isolate them in a separate > patch? This patch can follow after, which covers only > gitdiff_verify_name() returning -1 and its call sites. Yeah, I had planned to do something like that when developing the series but I forgot. Thanks, Christian. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html