On Sun, 8 Apr 2007, Junio C Hamano wrote: > Junio C Hamano <junkio@xxxxxxx> writes: > > > Dana How <danahow@xxxxxxxxx> writes: > > > >> Accept new 'limit' argument and check against it > >> before each group of writes. Update delta usability rules > >> for possibility of delta base being in a previously- > >> written pack. Inline sha1write_compressed() so we know > >> the exact size of the written data when it needs to be compressed. > >> > >> Signed-off-by: Dana How <how@xxxxxxxxxxxxxxxxxxxxxxx> > > > > My first reaction of open-coding sha1write_compressed() was > > "Ugh", but as you are removing the only user of that function, > > maybe this is not as bad as it looks. > > Having said that, I suspect that for other possible users of > that function we might have later, it would be a better > interface to add an optional 'limit' and 'prelude' to > sha1write_compressed(). The function would write prelude > followed by the compressed payload, only if they fit the limit. I'd wait for those possible future users to show up before doing such thing though. Nicolas - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html