Variable named 'verbose' in builtin/commit.c is consumed by git-status and git-commit so if a new verbose related behavior is introduced in git-commit, then it should not affect the behavior of git-status. One previous commit (title: commit: add a commit.verbose config variable) introduced a new config variable named commit.verbose, so care should be taken that it would not affect the behavior of status. Another previous commit (title: "parse-options.c: make OPTION_COUNTUP respect "unspecified" values") changes the initial value of verbose from 0 to -1. This can cause git-status to display a verbose output even when it isn't supposed to. Signed-off-by: Pranit Bauva <pranit.bauva@xxxxxxxxx> --- This is a split off from the previous patch 6/6 as suggested by Eric Sunshine. Signed-off-by: Pranit Bauva <pranit.bauva@xxxxxxxxx> --- t/t7507-commit-verbose.sh | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/t/t7507-commit-verbose.sh b/t/t7507-commit-verbose.sh index 2bb6d8d..00e0c3d 100755 --- a/t/t7507-commit-verbose.sh +++ b/t/t7507-commit-verbose.sh @@ -144,4 +144,14 @@ do " done +test_expect_success 'status ignores commit.verbose=true' ' + git -c commit.verbose=true status >actual && + ! grep "^diff --git" actual +' + +test_expect_success 'status does not verbose without --verbose' ' + git status >actual && + ! grep "^diff --git" actual +' + test_done -- 2.8.1 -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html