Dana How <danahow@xxxxxxxxx> writes:
> +/*
> + * Move this, the version in fast-import.c,
> + * and index_pack.c:readjust_pack_header_and_sha1 into sha1_file.c ?
> + */
> +static void fixup_header_footer(int pack_fd, unsigned char *pack_file_sha1,
> + char *pack_name, uint32_t object_count)
> +{
Indeed that is a very good point.
I admit I did not notice we already had the duplication between
fast-import.c and index-pack.c
Shawn, Nico, what do you think? Wouldn't it be better to
refactor them first, independent of Dana's series?
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html