Junio C Hamano <gitster@xxxxxxxxx> writes:
> Mike Hommey <mh@xxxxxxxxxxxx> writes:
>
>> Signed-off-by: Mike Hommey <mh@xxxxxxxxxxxx>
>
> I feel that this commit is under-explained. I think you should feel
> entitled to boast the goodness this brings to us louder in the log
> message.
>
> It bothers me somewhat that this ended up copying, not moving, a bit
> of code to call get-host-and-port helper, but I do not think it is a
> problem and it makes the codeflow easier to follow. Attempt to
> refactor it to reduce the duplication is likely to make it worse.
>
I hate to add a noise to the list, but while re-re-re-editing this
message before sending it out, I accidentally dropped an important
line here. I said (and then removed by mistake):
I like what this patch does.
> We used to allocate and prepare the child process structure 'conn',
> then realized that we are not going to use it anyway and discarded,
> only because the DIAG_URL check for SSH transport was done way too
> late. That wastage is removed by this change as well.
>
> Another change I notice is that DIAG_URL code for PROTO_SSH did not
> even kick in if transport_check_allowed("ssh") said no, but with
> this new code Diag is always given, which makes it consistent with
> PROTO_GIT codepath.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html