> On 29 Apr 2016, at 14:21, Matthieu Moy <Matthieu.Moy@xxxxxxxxxxxxxxx> wrote: > > Jeff King <peff@xxxxxxxx> writes: > >> On Fri, Apr 29, 2016 at 11:35:34AM +0200, larsxschneider@xxxxxxxxx wrote: >> >>> +# The follow numbers need to be adjusted when new documentation is added. >>> +test_file_count html 233 >>> +test_file_count xml 171 >>> +test_file_count 1 152 >> >> This seems like it will be really flaky and a pain in the future. I'm >> not really sure what it's accomplishing, either. The earlier steps would >> complain if something failed to render, wouldn't they? At some point we >> have to have some faith in "make doc". > > I agree. My proposal to check for a handful of generated files was just > because this extra paranoia was almost free (just 3 lines of code that > won't need particular maintenance). > > In this case, I'm afraid the maintenance cost is much bigger than the > expected benefits. I agree, too. I wasn't sure about this check. That's why I added the little comment above to point out the problem. Should I reroll? Thanks, Lars-- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html