On Thu, Apr 28, 2016 at 4:57 AM, Elia Pinto <gitter.spiros@xxxxxxxxx> wrote: > Implement the GIT_TRACE_CURL environment variable to allow a > greater degree of detail of GIT_CURL_VERBOSE, in particular > the complete transport header and all the data payload exchanged. > It might be useful if a particular situation could require a more > thorough debugging analysis. Document the new GIT_TRACE_CURL > environment variable. > > Helped-by: Torsten Bögershausen <tboegi@xxxxxx> > Helped-by: Ramsay Jones <ramsay@xxxxxxxxxxxxxxxxxxxx> > Helped-by: Junio C Hamano <gitster@xxxxxxxxx> > Helped-by: Eric Sunshine <sunshine@xxxxxxxxxxxxxx> > Helped-by: Jeff King <peff@xxxxxxxx> > Signed-off-by: Elia Pinto <gitter.spiros@xxxxxxxxx> > --- > Documentation/git.txt | 8 ++++ > http.c | 109 +++++++++++++++++++++++++++++++++++++++++++++++++- > http.h | 4 ++ > 3 files changed, 120 insertions(+), 1 deletion(-) > > diff --git a/Documentation/git.txt b/Documentation/git.txt > index 8afe349..958db0f 100644 > --- a/Documentation/git.txt > +++ b/Documentation/git.txt > @@ -1075,6 +1075,14 @@ of clones and fetches. > cloning of shallow repositories. > See 'GIT_TRACE' for available trace output options. > > +'GIT_TRACE_CURL':: > + Enables a curl full trace dump of all incoming and outgoing data, > + including descriptive information, of the git transport protocol. > + This is similar to doing curl --trace-ascii on the command line. > + This option overrides setting the GIT_CURL_VERBOSE environment > + variable. How does it overwrite the GIT_CURL_VERBOSE variable? After a quick `grep -r GIT_CURL_VERBOSE`, I notice 2 things: * apparently GIT_CURL_VERBOSE is used as a boolean, so I presume we assume True for GIT_CURL_VERBOSE, but extend it? * GIT_CURL_VERBOSE is not documented at all. (It is mentioned in the release notes for 2.3.0, not sure if that counts as documentation) As you know the area, care to send a documentation patch for GIT_CURL_VERBOSE? I am trying to understand how much more information I get by using GIT_TRACE_CURL instead of GIT_CURL_VERBOSE. GIT_TRACE_CURL follows the standard of GIT_TRACE_$subsystem, so I guess that will be the encouraged way of debugging and GIT_CURL_VERBOSE will not be encouraged to the user? -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html