On Wed, 2016-04-27 at 10:59 -0700, Junio C Hamano wrote: > There is another call to refname_is_safe() in resolve_ref_unsafe(), > which applies the sanity check to the string from a symref. We seem > to allow > > $ git symbolic-ref refs/heads/SSS refs/heads//master > > and we end up storing "ref: refs/heads//master" (or make a symbolic > link with doubled slashes), but the current code considers the > resulting symbolic link as "dangling". Again, this change moves the > rejection a bit earlier in the codepath, without changing the end > result, I'd think. I think we should disallow that -- refname_is_safe should probably call (or be replaced with calls to) check_refname_format. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html