On Tue, Apr 26, 2016 at 10:20 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > Christian Couder <christian.couder@xxxxxxxxx> writes: > >>> It's not clear why we need to declare buf here? Oh wait it is. It's just >>> moved from the start of the function. But why do it in this patch? >>> It seems unrelated to the general intent of the patch. No need to reroll >>> for this nit alone, it just took me a while to figure out it was an unrelated >>> thing. >> >> Yeah, I agree it's a bit unrelated. But rather than add another patch >> to an already long series just for this,... > > Isn't not doing the unrelated move at all a more sensible > alternative, if that change does not deserve its own place in the > series after all? Ok, I removed the unrelated move. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html