Hi Junio,
On Tue, 26 Apr 2016, Junio C Hamano wrote:
> @@ -1157,6 +1157,15 @@ static struct commit_list *collect_parents(struct commit *head_commit,
> return remoteheads;
> }
>
> +static void no_commit_impossible(const char *message)
> +{
> + if (!option_commit) {
> + warning("%s\n%s", _(message),
> + _("--no-commit is impossible"));
> + warning(_("In future versions of Git, this will become an error."));
> + }
> +}
I think this would be a step forward in usability, and I agree that this
is a great opportunity for the users who wish for this feature to get
involved and drive this forward, based on your excellent initial version.
I am not sure about this double negation "no_commit_impossible" (I only
understood what you meant because I had read the commit message first,
something I won't do when stumbling over this code later).
Maybe something like `disallow_no_commit`?
Ciao,
Dscho
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html