On Tue, Apr 26, 2016 at 10:46 AM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > Stefan Beller <sbeller@xxxxxxxxxx> writes: > >> I did not rebase this on 85705cfb (Merge branch 'ss/clone-depth-single-doc', >> 2016-01-20) or later, but worked on it with the base unchanged. > > Thanks, will replace. > >> diff --git a/t/t5614-clone-submodules.sh b/t/t5614-clone-submodules.sh >> new file mode 100755 >> index 0000000..62044c5 >> --- /dev/null >> +++ b/t/t5614-clone-submodules.sh >> @@ -0,0 +1,85 @@ >> +#!/bin/sh >> + >> +test_description='Test shallow cloning of repos with submodules' >> + >> +. ./test-lib.sh >> + >> +pwd=$(pwd) >> + >> +test_expect_success 'setup' ' >> + git checkout -b master && >> + test_commit commit1 && >> + test_commit commit2 && >> + mkdir sub && >> + ( >> + cd sub && >> + git init && >> + test_commit subcommit1 && >> + test_commit subcommit2 && >> + test_commit subcommit3 >> + ) && >> + git submodule add "file://$pwd/sub" sub && >> + git commit -m "add submodule" >> +' >> + >> +test_expect_success 'nonshallow clone implies nonshallow submodule' ' >> + test_when_finished "rm -rf super_clone" && >> + git clone --recurse-submodules "file://$pwd/." super_clone && > > All of these "$path/." made me wonder one thing. I know these URLs > that ends with slash-dot ought to work, but shouldn't they work > without them, too? The "consistency" in this test that ends > anything that would have ended with "$pwd" with "$pwd/." somewhat > bothered me. > Another case of me not thinking it through. There used to be just '.' in the former series with the --no-local option. And to make it a file url I just prefixed that dot without thinking if the dot is still needed. In case another reroll is needed, I'll fix that up, too. Thanks, Stefan -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html